Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 5 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 bool IsPrerendering(content::WebContents* web_contents) override { 74 bool IsPrerendering(content::WebContents* web_contents) override {
75 return is_prerendering_; 75 return is_prerendering_;
76 } 76 }
77 bool IsNewTabPageUrl(const GURL& url) override { return is_ntp_; } 77 bool IsNewTabPageUrl(const GURL& url) override { return is_ntp_; }
78 void set_is_prerendering(bool is_prerendering) { 78 void set_is_prerendering(bool is_prerendering) {
79 is_prerendering_ = is_prerendering; 79 is_prerendering_ = is_prerendering;
80 } 80 }
81 void set_is_ntp(bool is_ntp) { is_ntp_ = is_ntp; } 81 void set_is_ntp(bool is_ntp) { is_ntp_ = is_ntp; }
82 void RegisterObservers(PageLoadTracker* tracker) override { 82 void RegisterObservers(PageLoadTracker* tracker) override {
83 tracker->AddObserver(base::WrapUnique(new TestPageLoadMetricsObserver( 83 tracker->AddObserver(base::MakeUnique<TestPageLoadMetricsObserver>(
84 &updated_timings_, &complete_timings_, &observed_committed_urls_))); 84 &updated_timings_, &complete_timings_, &observed_committed_urls_));
85 } 85 }
86 const std::vector<PageLoadTiming>& updated_timings() const { 86 const std::vector<PageLoadTiming>& updated_timings() const {
87 return updated_timings_; 87 return updated_timings_;
88 } 88 }
89 const std::vector<PageLoadTiming>& complete_timings() const { 89 const std::vector<PageLoadTiming>& complete_timings() const {
90 return complete_timings_; 90 return complete_timings_;
91 } 91 }
92 92
93 // currently_committed_urls passed to OnStart(). 93 // currently_committed_urls passed to OnStart().
94 const std::vector<GURL>& observed_committed_urls_from_on_start() const { 94 const std::vector<GURL>& observed_committed_urls_from_on_start() const {
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 502
503 histogram_tester_.ExpectTotalCount( 503 histogram_tester_.ExpectTotalCount(
504 internal::kPageLoadCompletedAfterAppBackground, 2); 504 internal::kPageLoadCompletedAfterAppBackground, 2);
505 histogram_tester_.ExpectBucketCount( 505 histogram_tester_.ExpectBucketCount(
506 internal::kPageLoadCompletedAfterAppBackground, false, 1); 506 internal::kPageLoadCompletedAfterAppBackground, false, 1);
507 histogram_tester_.ExpectBucketCount( 507 histogram_tester_.ExpectBucketCount(
508 internal::kPageLoadCompletedAfterAppBackground, true, 1); 508 internal::kPageLoadCompletedAfterAppBackground, true, 1);
509 } 509 }
510 510
511 } // namespace page_load_metrics 511 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698