chrome/browser/media_galleries/linux/mtp_read_file_worker.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/linux/mtp_read_file_worker.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media_galleries/linux/mtp_read_file_worker.cc

diff --git a/chrome/browser/media_galleries/linux/mtp_read_file_worker.cc b/chrome/browser/media_galleries/linux/mtp_read_file_worker.cc

index aba6690c0cfe73e5b38065d13d4953d0b2f4be7c..c5a081d86b127070e58eb261bc605c03df20dcd5 100644

--- a/chrome/browser/media_galleries/linux/mtp_read_file_worker.cc

+++ b/chrome/browser/media_galleries/linux/mtp_read_file_worker.cc

@@ -51,8 +51,8 @@ void MTPReadFileWorker::WriteDataIntoSnapshotFile(

const SnapshotRequestInfo& request_info,

const base::File::Info& snapshot_file_info) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- ReadDataChunkFromDeviceFile(base::WrapUnique(

- new SnapshotFileDetails(request_info, snapshot_file_info)));

+ ReadDataChunkFromDeviceFile(

+ base::MakeUnique<SnapshotFileDetails>(request_info, snapshot_file_info));

}

void MTPReadFileWorker::ReadDataChunkFromDeviceFile(