chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa_data_provider.cc ('k') | chrome/browser/media_galleries/linux/mtp_read_file_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

diff --git a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

index 3e1625357042a0fe0cb203bcd4bc0d031b1325d2..51991ca16d7186414a33ba600a31c4be1214c545 100644

--- a/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

+++ b/chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc

@@ -80,8 +80,7 @@ void SafeMediaMetadataParser::OnParseMediaMetadataFinished(

// We need to make a scoped copy of this vector since it will be destroyed

// at the end of the IPC message handler.

std::unique_ptr<std::vector<metadata::AttachedImage>> attached_images_copy =

- base::WrapUnique(

- new std::vector<metadata::AttachedImage>(attached_images));

+ base::MakeUnique<std::vector<metadata::AttachedImage>>(attached_images);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,