Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2334603002: Fix SSLUITest.TestBadHTTPSDownload with PlzNavigate. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, browser-components-watch_chromium.org, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SSLUITest.TestBadHTTPSDownload with PlzNavigate. The problem was that some callbacks were using the RenderViewHost's IDs instead of the WebContents getter. BUG=504347 Committed: https://crrev.com/f260f2e8128cda7ce1d8936303ee23bba6e6ee37 Cr-Commit-Position: refs/heads/master@{#417970}

Patch Set 1 #

Patch Set 2 : fix android temporarily #

Total comments: 1

Patch Set 3 : fix android temporarily #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -77 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/download/download_controller.h View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/android/download/download_controller_base.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/android/download/mock_download_controller.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/android/download/mock_download_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/intercept_download_resource_throttle.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/intercept_download_resource_throttle.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/content_favicon_driver_browsertest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
jam
4 years, 3 months ago (2016-09-12 15:40:32 UTC) #8
scottmg
lgtm https://codereview.chromium.org/2334603002/diff/40001/chrome/browser/android/intercept_download_resource_throttle.cc File chrome/browser/android/intercept_download_resource_throttle.cc (right): https://codereview.chromium.org/2334603002/diff/40001/chrome/browser/android/intercept_download_resource_throttle.cc#newcode157 chrome/browser/android/intercept_download_resource_throttle.cc:157: wc_getter, must_download_, info); wc_getter_
4 years, 3 months ago (2016-09-12 16:33:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334603002/60001
4 years, 3 months ago (2016-09-12 16:54:33 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-12 17:51:45 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 17:53:44 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f260f2e8128cda7ce1d8936303ee23bba6e6ee37
Cr-Commit-Position: refs/heads/master@{#417970}

Powered by Google App Engine
This is Rietveld 408576698