Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3201)

Unified Diff: chrome/browser/android/download/download_controller.h

Issue 2334603002: Fix SSLUITest.TestBadHTTPSDownload with PlzNavigate. (Closed)
Patch Set: fix android temporarily Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/download/download_controller.h
diff --git a/chrome/browser/android/download/download_controller.h b/chrome/browser/android/download/download_controller.h
index 65e785c9142d8adf49951bc28a4ae5e348817413..ceeb0a2ff8574b70b31ed905bffd9e793e141422 100644
--- a/chrome/browser/android/download/download_controller.h
+++ b/chrome/browser/android/download/download_controller.h
@@ -76,10 +76,10 @@ class DownloadController : public DownloadControllerBase {
bool HasFileAccessPermission(ui::WindowAndroid* window_android);
// DownloadControllerBase implementation.
- void CreateGETDownload(int render_process_id,
- int render_view_id,
- bool must_download,
- const DownloadInfo& info) override;
+ void CreateGETDownload(
+ const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
+ bool must_download,
+ const DownloadInfo& info) override;
void OnDownloadStarted(content::DownloadItem* download_item) override;
void StartContextMenuDownload(const content::ContextMenuParams& params,
content::WebContents* web_contents,
@@ -92,15 +92,15 @@ class DownloadController : public DownloadControllerBase {
// DownloadItem::Observer interface.
void OnDownloadUpdated(content::DownloadItem* item) override;
- void StartAndroidDownload(int render_process_id,
- int render_view_id,
- bool must_download,
- const DownloadInfo& info);
- void StartAndroidDownloadInternal(int render_process_id,
- int render_view_id,
- bool must_download,
- const DownloadInfo& info,
- bool allowed);
+ void StartAndroidDownload(
+ const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
+ bool must_download,
+ const DownloadInfo& info);
+ void StartAndroidDownloadInternal(
+ const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
+ bool must_download,
+ const DownloadInfo& info,
+ bool allowed);
// The download item contains dangerous file types.
void OnDangerousDownload(content::DownloadItem *item);

Powered by Google App Engine
This is Rietveld 408576698