Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Issue 2334563002: Use modifed URLRequest API in net/url_request/url_request unittests (Closed)

Created:
4 years, 3 months ago by maksims (do not use this acc)
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use modifed URLRequest API in net/url_request/url_request unittests This cl splits the big CL with changes to net/ folder and has changes only to net/cert_net according to the changes to URLRequest API. What the big cl does: It modifies net/ clients that use URLRequest API as long as URLRequest::Read returns int net errors and URLRequest::Delegate and NetworkDelegate methods (for example, OnResponseStarted or OnCompleted) have int net_error in the arguments now. The reason behind splitting the CL into small one is that an android bot started to be unstable and unittests became flaky. It was not possible to locate the problem and the decision was to split the CL and upload small parts with a 6+ hours interval in order to make it possible to locate the problematic code. The big CL is located here - https://codereview.chromium.org/2265873002/ BUG=423484 Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9 Committed: https://crrev.com/b53724b562a2867ed633049f8ee5582c64871043 Cr-Original-Commit-Position: refs/heads/master@{#418014} Cr-Commit-Position: refs/heads/master@{#419106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -186 lines) Patch
M net/url_request/url_request_job_factory_impl_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 98 chunks +116 lines, -167 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
maksims (do not use this acc)
PTAL
4 years, 3 months ago (2016-09-14 05:52:00 UTC) #7
mmenke
On 2016/09/14 05:52:00, maksims wrote: > PTAL LGTM
4 years, 3 months ago (2016-09-15 16:32:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334563002/1
4 years, 3 months ago (2016-09-16 04:45:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 05:31:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 05:33:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b53724b562a2867ed633049f8ee5582c64871043
Cr-Commit-Position: refs/heads/master@{#419106}

Powered by Google App Engine
This is Rietveld 408576698