Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 2334563002: Use modifed URLRequest API in net/url_request/url_request unittests (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index d0dd374ded77f8bb6386e6b7cfe5e5ce104ddcbe..871bd4711c7bac66d39d184dec598471c996ad47 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -69,8 +69,7 @@ TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
request->Start();
base::RunLoop().Run();
- EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
- EXPECT_THAT(request->status().error(), IsError(ERR_UNKNOWN_URL_SCHEME));
+ EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, delegate.request_status());
}
TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
@@ -85,8 +84,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
request->Start();
base::RunLoop().Run();
- EXPECT_EQ(URLRequestStatus::SUCCESS, request->status().status());
- EXPECT_THAT(request->status().error(), IsOk());
+ EXPECT_EQ(OK, delegate.request_status());
}
TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
« no previous file with comments | « no previous file | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698