Fix Android strict-mode violation in GeoLocation info bar.

chrome/browser/geolocation/geolocation_infobar_delegate_android.h

Index: chrome/browser/geolocation/geolocation_infobar_delegate_android.h
diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate_android.h b/chrome/browser/geolocation/geolocation_infobar_delegate_android.h
index e247f7fe1bb51b49854d63d50ffa0be57511786c..4b7448a88d5ed38d56b9a88e8faf1934bf692951 100644
--- a/chrome/browser/geolocation/geolocation_infobar_delegate_android.h
+++ b/chrome/browser/geolocation/geolocation_infobar_delegate_android.h
@@ -10,7 +10,8 @@
 
 class GoogleLocationSettingsHelper;
 
-class GeolocationInfoBarDelegateAndroid : public GeolocationInfoBarDelegate {
+class GeolocationInfoBarDelegateAndroid : public GeolocationInfoBarDelegate,
+    public base::RefCountedThreadSafe<GeolocationInfoBarDelegateAndroid> {

[joth, 2013/08/20 23:07:21]

you can't just mix in ref-counting. The root base class (InfoBarDelegate)
already declares a public destructor so anyone might just delete these objects
outside of the ref-counting protocol

[acleung1, 2013/08/23 23:13:09]

removed.

  public:
   GeolocationInfoBarDelegateAndroid(
       InfoBarService* infobar_service,
@@ -20,15 +21,20 @@ class GeolocationInfoBarDelegateAndroid : public GeolocationInfoBarDelegate {
       int contents_unique_id,
       const std::string& display_languages);
 
- private:
+  virtual void Initialize(InfoBarService* infobar_service) OVERRIDE;
   virtual ~GeolocationInfoBarDelegateAndroid();

[joth, 2013/08/20 23:07:21]

(likewise you won't want a public d'tor here if you're making this ref-counted)

nit: \n before private:

[acleung1, 2013/08/23 23:13:09]

removed instead.

+ private:
 
   // ConfirmInfoBarDelegate:
   virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
   virtual bool Accept() OVERRIDE;
 
+  void CheckLocationSettings(InfoBarService* infobar_service);
+
   scoped_ptr<GoogleLocationSettingsHelper> google_location_settings_helper_;
 
+  bool is_allow_label;

[joth, 2013/08/20 23:07:21]

trailing _

[acleung1, 2013/08/23 23:13:09]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(GeolocationInfoBarDelegateAndroid);
 };