Fix Android strict-mode violation in GeoLocation info bar.

chrome/browser/geolocation/geolocation_infobar_delegate_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_DELEGATE_ANDROID_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/geolocation/geolocation_infobar_delegate.h"
 
 class GoogleLocationSettingsHelper;
 
-class GeolocationInfoBarDelegateAndroid : public GeolocationInfoBarDelegate {
+class GeolocationInfoBarDelegateAndroid : public GeolocationInfoBarDelegate,
+    public base::RefCountedThreadSafe<GeolocationInfoBarDelegateAndroid> {

[joth, 2013/08/20 23:07:21]

you can't just mix in ref-counting. The root base class (InfoBarDelegate)
already declares a public destructor so anyone might just delete these objects
outside of the ref-counting protocol

[acleung1, 2013/08/23 23:13:09]

removed.

  public:
   GeolocationInfoBarDelegateAndroid(
       InfoBarService* infobar_service,
       PermissionQueueController* controller,
       const PermissionRequestID& id,
       const GURL& requesting_frame_url,
       int contents_unique_id,
       const std::string& display_languages);
 
+  virtual void Initialize(InfoBarService* infobar_service) OVERRIDE;
+  virtual ~GeolocationInfoBarDelegateAndroid();

[joth, 2013/08/20 23:07:21]

(likewise you won't want a public d'tor here if you're making this ref-counted)

nit: \n before private:

[acleung1, 2013/08/23 23:13:09]

removed instead.

  private:
-  virtual ~GeolocationInfoBarDelegateAndroid();
 
   // ConfirmInfoBarDelegate:
   virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
   virtual bool Accept() OVERRIDE;
 
+  void CheckLocationSettings(InfoBarService* infobar_service);
+
   scoped_ptr<GoogleLocationSettingsHelper> google_location_settings_helper_;
 
+  bool is_allow_label;

[joth, 2013/08/20 23:07:21]

trailing _

[acleung1, 2013/08/23 23:13:09]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(GeolocationInfoBarDelegateAndroid);
 };
 
 #endif  // CHROME_BROWSER_GEOLOCATION_GEOLOCATION_INFOBAR_DELEGATE_ANDROID_H_