Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2334323002: Update annotation expected results that use /QuadPoints when appropriate (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
tonikitoo
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update annotation expected results that use /QuadPoints when appropriate In [1], PDFium to use /QuadPoints coordinates rather than /Rect coordinates, in accordance to the presence of /AP. CL here updated the expectation for some test cases. [1] https://codereview.chromium.org/2289293005/ Original Author: tonikitoo@igalia.com Original Code Review: https://codereview.chromium.org/2300183002/ R=tonikitoo@igalia.com Committed: https://pdfium.googlesource.com/pdfium_tests/+/1be7d4b99b9f873ea10808e9dac9e8156519252b

Patch Set 1 : Original CL #

Patch Set 2 : Update for ToT #

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 3 months ago (2016-09-13 20:54:54 UTC) #2
tonikitoo
On 2016/09/13 20:54:54, Lei Zhang (OOO) wrote: (informal) lgtm
4 years, 3 months ago (2016-09-13 20:57:11 UTC) #3
Lei Zhang
4 years, 3 months ago (2016-09-13 21:00:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1be7d4b99b9f873ea10808e9dac9e8156519252b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698