Two minor cleanups in remoting protocol.

Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.

Committed: https://crrev.com/d64a5f646a5137ad6b83802d9f54dd36d755038f
Cr-Commit-Position: refs/heads/master@{#418794}

[Sergey Ulanov, 2016-09-13 18:13:52]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-09-13 18:14:15]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-09-13 18:58:42]

Isn't this timestamp the one we use to calculate RTT for the non-WebRTC
protocol? If so, then I don't think we can remove it yet.

https://codereview.chromium.org/2334293002/diff/20001/remoting/proto/video.proto
File remoting/proto/video.proto (left):

https://codereview.chromium.org/2334293002/diff/20001/remoting/proto/video.pr...
remoting/proto/video.proto:66: optional int64 timestamp = 12;
Don't best practises suggest that you should mark it deprecated rather than
removing it?

[Sergey Ulanov, 2016-09-13 20:29:33]

On 2016/09/13 18:58:42, Jamie wrote:
> Isn't this timestamp the one we use to calculate RTT for the non-WebRTC
> protocol? If so, then I don't think we can remove it yet.

No. For RTT we use latest_event_timestamp, which is still there. timestamp was
added only for perf tests and I'm removing these tests in
https://codereview.chromium.org/2338693002/.

> 
>
https://codereview.chromium.org/2334293002/diff/20001/remoting/proto/video.proto
> File remoting/proto/video.proto (left):
> 
>
https://codereview.chromium.org/2334293002/diff/20001/remoting/proto/video.pr...
> remoting/proto/video.proto:66: optional int64 timestamp = 12;
> Don't best practises suggest that you should mark it deprecated rather than
> removing it?

The version of protobuf we use doesn't support deprecated fields. That's why we
have the comment on top to document all field IDs that were previously used.

[Jamie, 2016-09-14 00:12:48]

LGTM, but please add something to the description explaining why these are no
longer needed.

[Sergey Ulanov, 2016-09-14 00:27:46]

Description was changed from

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived() and timestamp in
VideoFrame protobuf.
==========

to

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.
==========

[Sergey Ulanov, 2016-09-14 00:27:54]

On 2016/09/14 00:12:48, Jamie wrote:
> LGTM, but please add something to the description explaining why these are no
> longer needed.

done

[Sergey Ulanov, 2016-09-14 00:27:58]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:28:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:55:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2016-09-14 19:12:28]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:15:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2016-09-15 06:09:41]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-15 06:09:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 06:42:26]

Description was changed from

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.
==========

to

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.
==========

[commit-bot: I haz the power, 2016-09-15 06:42:27]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-15 06:44:51]

Description was changed from

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.
==========

to

==========
Two minor cleanups in remoting protocol.

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.

Committed: https://crrev.com/d64a5f646a5137ad6b83802d9f54dd36d755038f
Cr-Commit-Position: refs/heads/master@{#418794}
==========

[commit-bot: I haz the power, 2016-09-15 06:44:53]

Patchset 1 (id:??) landed as
https://crrev.com/d64a5f646a5137ad6b83802d9f54dd36d755038f
Cr-Commit-Position: refs/heads/master@{#418794}

[Sergey Ulanov, 2016-10-14 19:37:21]

Patchset #2 (id:40001) has been deleted