Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: tracing/tracing/value/diagnostics/related_value_set.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)
Patch Set: fix rail_power_metric Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/diagnostics/related_value_map.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/diagnostics/related_value_set.html
diff --git a/tracing/tracing/value/diagnostics/related_value_set.html b/tracing/tracing/value/diagnostics/related_value_set.html
index a4106aefd2d959b4e39bb2b3d3bf773bd49fb4c6..27dfa04f99fa05729f79adfd2f6be730cf9f96fa 100644
--- a/tracing/tracing/value/diagnostics/related_value_set.html
+++ b/tracing/tracing/value/diagnostics/related_value_set.html
@@ -24,12 +24,12 @@ tr.exportTo('tr.v.d', function() {
}
/**
- * @param {!(tr.v.d.ValueRef|tr.v.Value)} v
+ * @param {!(tr.v.d.ValueRef|tr.v.Histogram)} v
*/
add(value) {
- if (!(value instanceof tr.v.Value) &&
+ if (!(value instanceof tr.v.Histogram) &&
!(value instanceof tr.v.d.ValueRef))
- throw new Error('Must be instanceof Value or ValueRef: ' + value);
+ throw new Error('Must be instanceof Histogram or ValueRef: ' + value);
if (this.valuesByGuid_.get(value.guid))
throw new Error('Tried to add same value twice');
@@ -67,10 +67,10 @@ tr.exportTo('tr.v.d', function() {
continue;
value = valueSet.lookup(guid);
- if (value instanceof tr.v.Value)
+ if (value instanceof tr.v.Histogram)
this.valuesByGuid_.set(guid, value);
else if (opt_required)
- throw new Error('Unable to find Value ' + guid);
+ throw new Error('Unable to find Histogram ' + guid);
}
}
« no previous file with comments | « tracing/tracing/value/diagnostics/related_value_map.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698