Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tracing/tracing/value/diagnostics/related_value_map.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)
Patch Set: fix rail_power_metric Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/diagnostics/related_value_map.html
diff --git a/tracing/tracing/value/diagnostics/related_value_map.html b/tracing/tracing/value/diagnostics/related_value_map.html
index f3b892a66d36592439ca142ac7388305433ad063..54f0aff9ea308d65a032b0a263f9bc565a6e8b53 100644
--- a/tracing/tracing/value/diagnostics/related_value_map.html
+++ b/tracing/tracing/value/diagnostics/related_value_map.html
@@ -20,33 +20,33 @@ tr.exportTo('tr.v.d', function() {
}
/**
- * Lookup a Value by name. Returns undefined if |name| is not found.
+ * Lookup a Histogram by name. Returns undefined if |name| is not found.
*
* @param {string} name
- * @return {!tr.v.d.ValueRef|!tr.v.Value|undefined}
+ * @return {!tr.v.d.ValueRef|!tr.v.Histogram|undefined}
*/
get(name) {
return this.valuesByName_.get(name);
}
/**
- * Add a Value by an explicit name to this map.
+ * Add a Histogram by an explicit name to this map.
*
* @param {string} name
- * @param {!(tr.v.d.ValueRef|tr.v.Value)} value
+ * @param {!(tr.v.d.ValueRef|tr.v.Histogram)} value
*/
set(name, value) {
- if (!(value instanceof tr.v.Value) &&
+ if (!(value instanceof tr.v.Histogram) &&
!(value instanceof tr.v.d.ValueRef))
- throw new Error('Must be instanceof Value or ValueRef: ' + value);
+ throw new Error('Must be instanceof Histogram or ValueRef: ' + value);
this.valuesByName_.set(name, value);
}
/**
- * Add a Value implicitly by its own name to this map.
+ * Add a Histogram implicitly by its own name to this map.
*
- * @param {!(tr.v.d.ValueRef|tr.v.Value)} value
+ * @param {!(tr.v.d.ValueRef|tr.v.Histogram)} value
*/
add(value) {
this.set(value.name, value);
@@ -79,10 +79,10 @@ tr.exportTo('tr.v.d', function() {
var guid = value.guid;
value = valueSet.lookup(guid);
- if (value instanceof tr.v.Value)
+ if (value instanceof tr.v.Histogram)
this.valuesByName_.set(name, value);
else if (opt_required)
- throw new Error('Unable to find Value ' + guid);
+ throw new Error('Unable to find Histogram ' + guid);
}
}
« no previous file with comments | « tracing/tracing/value/diagnostics/composition_test.html ('k') | tracing/tracing/value/diagnostics/related_value_set.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698