Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Remove deprecation warning for now. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
index 716e900f270a81d1ada2fa086b803f9036d7b42f..c9ccb345324468ce1a27f2e27d2028f663d8b57f 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
@@ -5,6 +5,7 @@
#include "core/dom/custom/CustomElementUpgradeSorter.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/StringOrDictionary.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
@@ -27,8 +28,8 @@ class CustomElementUpgradeSorterTest : public ::testing::Test {
Element* createElementWithId(const char* localName, const char* id) {
NonThrowableExceptionState noExceptions;
- Element* element =
- document()->createElement(localName, AtomicString(), noExceptions);
+ Element* element = document()->createElement(
+ localName, StringOrDictionary(), noExceptions);
element->setAttribute(HTMLNames::idAttr, id);
return element;
}
@@ -52,7 +53,7 @@ class CustomElementUpgradeSorterTest : public ::testing::Test {
TEST_F(CustomElementUpgradeSorterTest, inOtherDocument_notInSet) {
NonThrowableExceptionState noExceptions;
Element* element =
- document()->createElement("a-a", AtomicString(), noExceptions);
+ document()->createElement("a-a", StringOrDictionary(), noExceptions);
Document* otherDocument = HTMLDocument::create();
otherDocument->appendChild(element);
@@ -71,7 +72,7 @@ TEST_F(CustomElementUpgradeSorterTest, inOtherDocument_notInSet) {
TEST_F(CustomElementUpgradeSorterTest, oneCandidate) {
NonThrowableExceptionState noExceptions;
Element* element =
- document()->createElement("a-a", AtomicString(), noExceptions);
+ document()->createElement("a-a", StringOrDictionary(), noExceptions);
document()->documentElement()->appendChild(element);
CustomElementUpgradeSorter sorter;
« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScopeTest.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698