Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Remove deprecation warning for now. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
index 082ff450048bd7f7ee8a4abd1ea6fb713c72e3c4..a5f1335f8666711ab11418cb594d6f468803c4d1 100644
--- a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
@@ -4,6 +4,7 @@
#include "core/dom/TreeScope.h"
+#include "bindings/core/v8/StringOrDictionary.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
#include "core/dom/shadow/ShadowRoot.h"
@@ -15,8 +16,8 @@ TEST(TreeScopeTest, CommonAncestorOfSameTrees) {
Document* document = Document::create();
EXPECT_EQ(document, document->commonAncestorTreeScope(*document));
- Element* html =
- document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot =
html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -29,8 +30,8 @@ TEST(TreeScopeTest, CommonAncestorOfInclusiveTrees) {
// shadowRoot
Document* document = Document::create();
- Element* html =
- document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot =
html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -45,14 +46,14 @@ TEST(TreeScopeTest, CommonAncestorOfSiblingTrees) {
// A B
Document* document = Document::create();
- Element* html =
- document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head =
- document->createElement("head", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
html->appendChild(head);
- Element* body =
- document->createElement("body", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
html->appendChild(body);
ShadowRoot* shadowRootA =
@@ -72,14 +73,14 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
// A
Document* document = Document::create();
- Element* html =
- document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head =
- document->createElement("head", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
html->appendChild(head);
- Element* body =
- document->createElement("body", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", StringOrDictionary(),
+ ASSERT_NO_EXCEPTION);
html->appendChild(body);
ShadowRoot* shadowRootY =
@@ -88,7 +89,7 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
body->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
Element* divInY =
- document->createElement("div", nullAtom, ASSERT_NO_EXCEPTION);
+ document->createElement("div", StringOrDictionary(), ASSERT_NO_EXCEPTION);
shadowRootY->appendChild(divInY);
ShadowRoot* shadowRootA =
divInY->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);

Powered by Google App Engine
This is Rietveld 408576698