Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index efda275544b26e10c0d9b54789e4e30707001c57..cb6ef752d266c64c63255f4ea61db02899570a2d 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -376,6 +376,9 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
case UseCounter::NavigatorPointerEnabled:
return "Navigator.pointerEnabled is a non-standard API added for experiments only. It will be removed in near future.";
+ case UseCounter::DocumentCreateElement2ndArg:
dominicc (has gone to gerrit) 2016/09/15 01:19:24 Maybe give this a more descriptive name, because c
+ return "Document.createElement second argument string will be replaced in near future with the dictionary. See https://dom.spec.whatwg.org/#dom-document-createelement.";
dominicc (has gone to gerrit) 2016/09/15 01:19:24 Maybe make this more explicit: Change to passing a
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698