Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
index 1f356b417fc342d851b5ac01885e28b4072e0293..74da00aef6f521ac077cd5b88908f10e0e19365a 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp
@@ -4,6 +4,7 @@
#include "core/dom/custom/CustomElementUpgradeSorter.h"
+#include "bindings/core/v8/ElementCreationOptionsOrString.h"
#include "bindings/core/v8/ExceptionState.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
@@ -35,7 +36,7 @@ protected:
{
NonThrowableExceptionState noExceptions;
Element* element =
- document()->createElement(localName, AtomicString(), noExceptions);
+ document()->createElement(localName, ElementCreationOptionsOrString::fromString(emptyString()), noExceptions);
element->setAttribute(HTMLNames::idAttr, id);
return element;
}
@@ -63,7 +64,7 @@ TEST_F(CustomElementUpgradeSorterTest, inOtherDocument_notInSet)
{
NonThrowableExceptionState noExceptions;
Element* element =
- document()->createElement("a-a", AtomicString(), noExceptions);
+ document()->createElement("a-a", ElementCreationOptionsOrString::fromString(emptyString()), noExceptions);
Document* otherDocument = HTMLDocument::create();
otherDocument->appendChild(element);
@@ -83,7 +84,7 @@ TEST_F(CustomElementUpgradeSorterTest, oneCandidate)
{
NonThrowableExceptionState noExceptions;
Element* element =
- document()->createElement("a-a", AtomicString(), noExceptions);
+ document()->createElement("a-a", ElementCreationOptionsOrString::fromString(emptyString()), noExceptions);
document()->documentElement()->appendChild(element);
CustomElementUpgradeSorter sorter;

Powered by Google App Engine
This is Rietveld 408576698