Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
index 95987c2b44137bfb601a3302fbb602aa4070de29..9a8bdf26a865ba277254c83466c48e5934c85825 100644
--- a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
@@ -4,6 +4,7 @@
#include "core/dom/TreeScope.h"
+#include "bindings/core/v8/ElementCreationOptionsOrString.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
#include "core/dom/shadow/ShadowRoot.h"
@@ -16,7 +17,7 @@ TEST(TreeScopeTest, CommonAncestorOfSameTrees)
Document* document = Document::create();
EXPECT_EQ(document, document->commonAncestorTreeScope(*document));
- Element* html = document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot = html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
EXPECT_EQ(shadowRoot, shadowRoot->commonAncestorTreeScope(*shadowRoot));
@@ -29,7 +30,7 @@ TEST(TreeScopeTest, CommonAncestorOfInclusiveTrees)
// shadowRoot
Document* document = Document::create();
- Element* html = document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRoot = html->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -44,11 +45,11 @@ TEST(TreeScopeTest, CommonAncestorOfSiblingTrees)
// A B
Document* document = Document::create();
- Element* html = document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head = document->createElement("head", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
html->appendChild(head);
- Element* body = document->createElement("body", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
html->appendChild(body);
ShadowRoot* shadowRootA = head->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -67,17 +68,17 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths)
// A
Document* document = Document::create();
- Element* html = document->createElement("html", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* html = document->createElement("html", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
document->appendChild(html, ASSERT_NO_EXCEPTION);
- Element* head = document->createElement("head", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* head = document->createElement("head", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
html->appendChild(head);
- Element* body = document->createElement("body", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* body = document->createElement("body", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
html->appendChild(body);
ShadowRoot* shadowRootY = head->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
ShadowRoot* shadowRootB = body->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
- Element* divInY = document->createElement("div", nullAtom, ASSERT_NO_EXCEPTION);
+ Element* divInY = document->createElement("div", ElementCreationOptionsOrString::fromString(emptyString()), ASSERT_NO_EXCEPTION);
shadowRootY->appendChild(divInY);
ShadowRoot* shadowRootA = divInY->createShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);

Powered by Google App Engine
This is Rietveld 408576698