Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2334163004: Revert "[Chromecast] Only include all libstdc++/libgcc symbols in executable as needed" (Closed)

Created:
4 years, 3 months ago by antz1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, sadrul, halliwell+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Chromecast] Only include all libstdc++/libgcc symbols in executable as needed" Reason for revert: The original fix is opt-in, which causes unit test binaries to miss symbols. I will reimplement an opt-out for binaries that we do not want to whole-archive libs. Original issue description: >> All chromecast executable include all libstdc++/libgcc symbols by default >> due to b/25566835. Added a config for --whole-archive for only ones that >> depend on shared libs. ~700kb saving per executable. BUG=internal b/31417380 This reverts commit 92947f235fcf22912990029925b4154e7ea08f74. Committed: https://crrev.com/19adc908726781b299b441d3142f29143f234753 Cr-Commit-Position: refs/heads/master@{#418640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M build/config/chromecast/BUILD.gn View 3 chunks +9 lines, -19 lines 0 comments Download
M chromecast/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/crash/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
antz1
4 years, 3 months ago (2016-09-14 00:37:13 UTC) #3
antz1
4 years, 3 months ago (2016-09-14 17:06:35 UTC) #5
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-14 17:09:11 UTC) #6
bcf
lgtm
4 years, 3 months ago (2016-09-14 17:15:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334163004/1
4 years, 3 months ago (2016-09-14 18:09:15 UTC) #9
wzhong
lgtm
4 years, 3 months ago (2016-09-14 18:18:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/259404)
4 years, 3 months ago (2016-09-14 18:18:05 UTC) #12
slan
lgtm
4 years, 3 months ago (2016-09-14 18:42:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334163004/1
4 years, 3 months ago (2016-09-14 18:44:44 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 19:36:46 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:39:50 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19adc908726781b299b441d3142f29143f234753
Cr-Commit-Position: refs/heads/master@{#418640}

Powered by Google App Engine
This is Rietveld 408576698