chromecast/BUILD.gn - Issue 2334163004: Revert "[Chromecast] Only include all libstdc++/libgcc symbols in executable as needed"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/BUILD.gn

Issue 2334163004: Revert "[Chromecast] Only include all libstdc++/libgcc symbols in executable as needed" (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/BUILD.gn

diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn

index 8d3d5f3a592f415ba040b02857d8ae205865c408..f4bb07f37a8850a5bb706a2bf642b64f88eba898 100644

--- a/chromecast/BUILD.gn

+++ b/chromecast/BUILD.gn

@@ -223,10 +223,6 @@ executable("cast_shell") {

if (chromecast_branding != "public") {

deps += [ "//chromecast/internal:cast_shell_internal" ]

}

- # Whole archiving libgcc.a and libstdc++ is needed if dynamic share libs are

- # used, see b/25566835.

- configs += [ "//build/config/chromecast:executable_whole_archive_config" ]

}

repack("cast_shell_pak") {

« no previous file with comments | « build/config/chromecast/BUILD.gn ('k') | chromecast/crash/BUILD.gn » ('j') | no next file with comments »