net/udp/udp_socket_win.h - Issue 2333923004: Extracting NetLog inner classes into their own classes. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1381)

My Issues | Starred Open | Closed | All

Unified Diff: net/udp/udp_socket_win.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/udp/udp_socket_unittest.cc ('k') | net/udp/udp_socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/udp/udp_socket_win.h

diff --git a/net/udp/udp_socket_win.h b/net/udp/udp_socket_win.h

index 59eee4d2e47d2b9d4d7c10769bad4b91b03f84bf..87b42effd05e12362a153203145532ae79464230 100644

--- a/net/udp/udp_socket_win.h

+++ b/net/udp/udp_socket_win.h

@@ -24,13 +24,15 @@

#include "net/base/net_export.h"

#include "net/base/network_change_notifier.h"

#include "net/base/rand_callback.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

#include "net/udp/datagram_socket.h"

#include "net/udp/diff_serv_code_point.h"

namespace net {

class IPAddress;

+class NetLog;

+struct NetLogSource;

class NET_EXPORT UDPSocketWin

: NON_EXPORTED_BASE(public base::NonThreadSafe),

@@ -39,7 +41,7 @@ class NET_EXPORT UDPSocketWin

UDPSocketWin(DatagramSocket::BindType bind_type,

const RandIntCallback& rand_int_cb,

net::NetLog* net_log,

- const net::NetLog::Source& source);

+ const net::NetLogSource& source);

~UDPSocketWin() override;

// Opens the socket.

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/udp/udp_socket_unittest.cc ('k') | net/udp/udp_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698