net/udp/udp_socket_posix.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_posix.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_socket_posix.cc

diff --git a/net/udp/udp_socket_posix.cc b/net/udp/udp_socket_posix.cc

index 296b540ea2a6bdb7207c7b2033a747bcfaa59822..41ef0e922fa01103ab0f8d8122a2bb7b45c1b344 100644

--- a/net/udp/udp_socket_posix.cc

+++ b/net/udp/udp_socket_posix.cc

@@ -29,6 +29,7 @@

#include "net/base/sockaddr_storage.h"

#include "net/log/net_log.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_source.h"

#include "net/log/net_log_source_type.h"

#include "net/socket/socket_descriptor.h"

#include "net/udp/udp_net_log_parameters.h"

@@ -76,7 +77,7 @@ int GetIPv4AddressFromIndex(int socket, uint32_t index, uint32_t* address) {

UDPSocketPosix::UDPSocketPosix(DatagramSocket::BindType bind_type,

const RandIntCallback& rand_int_cb,

net::NetLog* net_log,

- const net::NetLog::Source& source)

+ const net::NetLogSource& source)

: socket_(kInvalidSocket),

addr_family_(0),

is_connected_(false),