net/udp/udp_net_log_parameters.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_net_log_parameters.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_net_log_parameters.cc

diff --git a/net/udp/udp_net_log_parameters.cc b/net/udp/udp_net_log_parameters.cc

index f52d50c4081591fbf1cba1c80aa0f58450348f52..471f4e475f6adba88c23fd6bb330fa65836803d0 100644

--- a/net/udp/udp_net_log_parameters.cc

+++ b/net/udp/udp_net_log_parameters.cc

@@ -42,7 +42,7 @@ std::unique_ptr<base::Value> NetLogUDPConnectCallback(

} // namespace

-NetLog::ParametersCallback CreateNetLogUDPDataTranferCallback(

+NetLogParametersCallback CreateNetLogUDPDataTranferCallback(

int byte_count,

const char* bytes,

const IPEndPoint* address) {

@@ -50,7 +50,7 @@ NetLog::ParametersCallback CreateNetLogUDPDataTranferCallback(

return base::Bind(&NetLogUDPDataTranferCallback, byte_count, bytes, address);

}

-NetLog::ParametersCallback CreateNetLogUDPConnectCallback(

+NetLogParametersCallback CreateNetLogUDPConnectCallback(

const IPEndPoint* address,

NetworkChangeNotifier::NetworkHandle network) {

DCHECK(address);