net/tools/quic/quic_simple_client.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_simple_client.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_simple_client.cc

diff --git a/net/tools/quic/quic_simple_client.cc b/net/tools/quic/quic_simple_client.cc

index 805b89e332952e60243273296ce9c9738529dc94..48126191ad2a12f1eab73f3d6bbdd812a31c82cb 100644

--- a/net/tools/quic/quic_simple_client.cc

+++ b/net/tools/quic/quic_simple_client.cc

@@ -12,6 +12,8 @@

#include "net/base/net_errors.h"

#include "net/http/http_request_info.h"

#include "net/http/http_response_info.h"

+#include "net/log/net_log_source.h"

+#include "net/log/net_log_with_source.h"

#include "net/quic/chromium/quic_chromium_alarm_factory.h"

#include "net/quic/chromium/quic_chromium_connection_helper.h"

#include "net/quic/chromium/quic_chromium_packet_reader.h"

@@ -74,7 +76,7 @@ bool QuicSimpleClient::CreateUDPSocketAndBind(IPEndPoint server_address,

int bind_to_port) {

std::unique_ptr<UDPClientSocket> socket(

new UDPClientSocket(DatagramSocket::DEFAULT_BIND, RandIntCallback(),

- &net_log_, NetLog::Source()));

+ &net_log_, NetLogSource()));

int address_family = server_address.GetSockAddrFamily();

if (bind_to_address.size() != 0) {