net/test/embedded_test_server/embedded_test_server.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/embedded_test_server/embedded_test_server.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/embedded_test_server/embedded_test_server.cc

diff --git a/net/test/embedded_test_server/embedded_test_server.cc b/net/test/embedded_test_server/embedded_test_server.cc

index d9aeeeefd663c73440ecac096700ba30283163de..7f861d674c03b03319ad5ab8fe6e4233a8236328 100644

--- a/net/test/embedded_test_server/embedded_test_server.cc

+++ b/net/test/embedded_test_server/embedded_test_server.cc

@@ -25,6 +25,7 @@

#include "net/base/net_errors.h"

#include "net/cert/pem_tokenizer.h"

#include "net/cert/test_root_certs.h"

+#include "net/log/net_log_source.h"

#include "net/socket/ssl_server_socket.h"

#include "net/socket/stream_socket.h"

#include "net/socket/tcp_server_socket.h"

@@ -91,7 +92,7 @@ bool EmbeddedTestServer::Start() {

bool EmbeddedTestServer::InitializeAndListen() {

DCHECK(!Started());

- listen_socket_.reset(new TCPServerSocket(nullptr, NetLog::Source()));

+ listen_socket_.reset(new TCPServerSocket(nullptr, NetLogSource()));

int result = listen_socket_->ListenWithAddressAndPort("127.0.0.1", 0, 10);

if (result) {