net/spdy/spdy_session.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(588)

My Issues | Starred Open | Closed | All

Unified Diff: net/spdy/spdy_session.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index 0c42089a35170846e6e5744b402389442c5d69a4..4fc8c23a4a70ea728e870941d655403d0a0d764b 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -38,8 +38,11 @@

#include "net/http/http_util.h"

#include "net/http/transport_security_state.h"

#include "net/log/net_log.h"

+#include "net/log/net_log_capture_mode.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_source.h"

#include "net/log/net_log_source_type.h"

+#include "net/log/net_log_with_source.h"

#include "net/proxy/proxy_server.h"

#include "net/socket/ssl_client_socket.h"

#include "net/spdy/spdy_buffer_producer.h"

@@ -117,7 +120,7 @@ std::unique_ptr<base::Value> NetLogSpdySessionCallback(

}

std::unique_ptr<base::Value> NetLogSpdyInitializedCallback(

- NetLog::Source source,

+ NetLogSource source,

NetLogCaptureMode /* capture_mode */) {

std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());

if (source.IsValid()) {

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698