net/spdy/spdy_proxy_client_socket_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_proxy_client_socket_unittest.cc

diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc

index 54e2da1d4a9e34231b406b5cb7d95fde58ac865b..7c09e576b03456b80a190dddecc750ddb5bd14a3 100644

--- a/net/spdy/spdy_proxy_client_socket_unittest.cc

+++ b/net/spdy/spdy_proxy_client_socket_unittest.cc

@@ -17,8 +17,8 @@

#include "net/dns/mock_host_resolver.h"

#include "net/http/http_response_headers.h"

#include "net/http/http_response_info.h"

-#include "net/log/net_log.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_source.h"

#include "net/log/test_net_log.h"

#include "net/log/test_net_log_entry.h"

#include "net/log/test_net_log_util.h"

@@ -1253,7 +1253,7 @@ TEST_F(SpdyProxyClientSocketTest, NetLog) {

ResumeAndRun();

AssertSyncReadEquals(kMsg1, kLen1);

- NetLog::Source sock_source = sock_->NetLog().source();

+ NetLogSource sock_source = sock_->NetLog().source();

sock_.reset();

TestNetLogEntry::List entry_list;