net/socket/tcp_socket_win.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(286)

My Issues | Starred Open | Closed | All

Unified Diff: net/socket/tcp_socket_win.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/socket/tcp_socket_win.h ('k') | net/socket/transport_client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/tcp_socket_win.cc

diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc

index 8ae06aa98193eb6c3da2afba573fac9c97d9a7e5..d879a5ee95e7fdf62b22ee4f3ff17d545396db0b 100644

--- a/net/socket/tcp_socket_win.cc

+++ b/net/socket/tcp_socket_win.cc

@@ -24,7 +24,9 @@

#include "net/base/sockaddr_storage.h"

#include "net/base/winsock_init.h"

#include "net/base/winsock_util.h"

+#include "net/log/net_log.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_source.h"

#include "net/log/net_log_source_type.h"

#include "net/socket/socket_descriptor.h"

#include "net/socket/socket_net_log_params.h"

@@ -246,7 +248,7 @@ void TCPSocketWin::Core::WriteDelegate::OnObjectSignaled(

TCPSocketWin::TCPSocketWin(

std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,

net::NetLog* net_log,

- const net::NetLog::Source& source)

+ const net::NetLogSource& source)

: socket_(INVALID_SOCKET),

socket_performance_watcher_(std::move(socket_performance_watcher)),

accept_event_(WSA_INVALID_EVENT),

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/socket/tcp_socket_win.h ('k') | net/socket/transport_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698