net/socket/socks_client_socket_pool.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks_client_socket_pool.cc

diff --git a/net/socket/socks_client_socket_pool.cc b/net/socket/socks_client_socket_pool.cc

index 659dcdf521a1d12b8b8a733dd0e3929652a8013e..0e2464d79443f162e3024fed809c245fc77d95bc 100644

--- a/net/socket/socks_client_socket_pool.cc

+++ b/net/socket/socks_client_socket_pool.cc

@@ -12,6 +12,7 @@

#include "base/values.h"

#include "net/base/net_errors.h"

#include "net/log/net_log_source_type.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/client_socket_factory.h"

#include "net/socket/client_socket_handle.h"

#include "net/socket/client_socket_pool_base.h"

@@ -21,6 +22,8 @@

namespace net {

+class NetLog;

SOCKSSocketParams::SOCKSSocketParams(

const scoped_refptr<TransportSocketParams>& proxy_server,

bool socks_v5,