Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: net/socket/socket_net_log_params.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socket_net_log_params.cc
diff --git a/net/socket/socket_net_log_params.cc b/net/socket/socket_net_log_params.cc
index d53bd8a62860fb660b17debbd253d3dcd82c83de..ef05939dc3f27a4ca5832e646e16c32deb5b4356 100644
--- a/net/socket/socket_net_log_params.cc
+++ b/net/socket/socket_net_log_params.cc
@@ -10,6 +10,7 @@
#include "base/values.h"
#include "net/base/host_port_pair.h"
#include "net/base/ip_endpoint.h"
+#include "net/log/net_log_capture_mode.h"
namespace net {
@@ -55,22 +56,22 @@ std::unique_ptr<base::Value> NetLogSourceAddressCallback(
} // namespace
-NetLog::ParametersCallback CreateNetLogSocketErrorCallback(int net_error,
- int os_error) {
+NetLogParametersCallback CreateNetLogSocketErrorCallback(int net_error,
+ int os_error) {
return base::Bind(&NetLogSocketErrorCallback, net_error, os_error);
}
-NetLog::ParametersCallback CreateNetLogHostPortPairCallback(
+NetLogParametersCallback CreateNetLogHostPortPairCallback(
const HostPortPair* host_and_port) {
return base::Bind(&NetLogHostPortPairCallback, host_and_port);
}
-NetLog::ParametersCallback CreateNetLogIPEndPointCallback(
+NetLogParametersCallback CreateNetLogIPEndPointCallback(
const IPEndPoint* address) {
return base::Bind(&NetLogIPEndPointCallback, address);
}
-NetLog::ParametersCallback CreateNetLogSourceAddressCallback(
+NetLogParametersCallback CreateNetLogSourceAddressCallback(
const struct sockaddr* net_address,
socklen_t address_len) {
return base::Bind(&NetLogSourceAddressCallback, net_address, address_len);

Powered by Google App Engine
This is Rietveld 408576698