net/proxy/proxy_resolver_factory_mojo.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_factory_mojo.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_factory_mojo.cc

diff --git a/net/proxy/proxy_resolver_factory_mojo.cc b/net/proxy/proxy_resolver_factory_mojo.cc

index ee3fa4c8276f2dd9436b10b248f952e9aa20ff36..0a14cac3589f0f8f233072c232874c610e66c3d7 100644

--- a/net/proxy/proxy_resolver_factory_mojo.cc

+++ b/net/proxy/proxy_resolver_factory_mojo.cc

@@ -21,7 +21,10 @@

#include "net/dns/mojo_host_resolver_impl.h"

#include "net/interfaces/host_resolver_service.mojom.h"

#include "net/interfaces/proxy_resolver_service.mojom.h"

+#include "net/log/net_log.h"

+#include "net/log/net_log_capture_mode.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_with_source.h"

#include "net/proxy/mojo_proxy_resolver_factory.h"

#include "net/proxy/mojo_proxy_type_converters.h"

#include "net/proxy/proxy_info.h"

@@ -30,6 +33,7 @@

#include "net/proxy/proxy_resolver_script_data.h"

namespace net {

namespace {

std::unique_ptr<base::Value> NetLogErrorCallback(