Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: net/log/write_to_file_net_log_observer_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/write_to_file_net_log_observer_unittest.cc
diff --git a/net/log/write_to_file_net_log_observer_unittest.cc b/net/log/write_to_file_net_log_observer_unittest.cc
index dc134821b7949cc4f78b93b5e11b7a6e5b56ff21..06c2065e754daef93cce4db7ed8c2dddafed0c39 100644
--- a/net/log/write_to_file_net_log_observer_unittest.cc
+++ b/net/log/write_to_file_net_log_observer_unittest.cc
@@ -14,7 +14,9 @@
#include "base/json/json_reader.h"
#include "base/values.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_entry.h"
#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_source.h"
#include "net/log/net_log_source_type.h"
#include "net/log/net_log_util.h"
#include "net/url_request/url_request.h"
@@ -91,11 +93,11 @@ TEST_F(WriteToFileNetLogObserverTest, GeneratesValidJSONWithOneEvent) {
logger->StartObserving(&net_log_, std::move(file), nullptr, nullptr);
const int kDummyId = 1;
- NetLog::Source source(NetLogSourceType::HTTP2_SESSION, kDummyId);
- NetLog::EntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
- NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
- NULL);
- NetLog::Entry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
+ NetLogSource source(NetLogSourceType::HTTP2_SESSION, kDummyId);
+ NetLogEntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
+ NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
+ NULL);
+ NetLogEntry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
logger->OnAddEntry(entry);
logger->StopObserving(nullptr);
logger.reset();
@@ -122,11 +124,11 @@ TEST_F(WriteToFileNetLogObserverTest, GeneratesValidJSONWithMultipleEvents) {
logger->StartObserving(&net_log_, std::move(file), nullptr, nullptr);
const int kDummyId = 1;
- NetLog::Source source(NetLogSourceType::HTTP2_SESSION, kDummyId);
- NetLog::EntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
- NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
- NULL);
- NetLog::Entry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
+ NetLogSource source(NetLogSourceType::HTTP2_SESSION, kDummyId);
+ NetLogEntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
+ NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
+ NULL);
+ NetLogEntry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
// Add the entry multiple times.
logger->OnAddEntry(entry);

Powered by Google App Engine
This is Rietveld 408576698