net/log/trace_net_log_observer_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/trace_net_log_observer_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/trace_net_log_observer_unittest.cc

diff --git a/net/log/trace_net_log_observer_unittest.cc b/net/log/trace_net_log_observer_unittest.cc

index cb2c00b2521e5acda1f33483f424e62de84e3541..60c54ee0f9fbd74941f687756c3adb5a81ad864e 100644

--- a/net/log/trace_net_log_observer_unittest.cc

+++ b/net/log/trace_net_log_observer_unittest.cc

@@ -18,9 +18,10 @@

#include "base/trace_event/trace_event.h"

#include "base/trace_event/trace_event_impl.h"

#include "base/values.h"

-#include "net/log/net_log.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_parameters_callback.h"

#include "net/log/net_log_source_type.h"

+#include "net/log/net_log_with_source.h"

#include "net/log/test_net_log.h"

#include "net/log/test_net_log_entry.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -324,7 +325,7 @@ TEST_F(TraceNetLogObserverTest, CreateObserverAfterTracingStarts) {

TEST_F(TraceNetLogObserverTest, EventsWithAndWithoutParameters) {

trace_net_log_observer()->WatchForTraceStart(net_log());

EnableTraceLog();

- NetLog::ParametersCallback net_log_callback;

+ NetLogParametersCallback net_log_callback;

std::string param = "bar";

net_log_callback = NetLog::StringCallback("foo", &param);