net/log/trace_net_log_observer.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/trace_net_log_observer.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/trace_net_log_observer.h

diff --git a/net/log/trace_net_log_observer.h b/net/log/trace_net_log_observer.h

index 08907f2e230631438b47964c33d5a5ea76400d5a..4c8b572c5f201507ff2798e5a9edb63d7ffee150 100644

--- a/net/log/trace_net_log_observer.h

+++ b/net/log/trace_net_log_observer.h

@@ -22,7 +22,7 @@ class NET_EXPORT TraceNetLogObserver

~TraceNetLogObserver() override;

// net::NetLog::ThreadSafeObserver implementation:

- void OnAddEntry(const NetLog::Entry& entry) override;

+ void OnAddEntry(const NetLogEntry& entry) override;

// Start to watch for TraceLog enable and disable events.

// This can't be called if already watching for events.