net/log/test_net_log_entry.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/test_net_log_entry.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/test_net_log_entry.cc

diff --git a/net/log/test_net_log_entry.cc b/net/log/test_net_log_entry.cc

index 256d133a134aafd2e3eb02cc73ef77f1a66079e9..e8beb757c3197afaddf3b769360b3d43e030e3e3 100644

--- a/net/log/test_net_log_entry.cc

+++ b/net/log/test_net_log_entry.cc

@@ -14,7 +14,7 @@ namespace net {

TestNetLogEntry::TestNetLogEntry(NetLogEventType type,

const base::TimeTicks& time,

- NetLog::Source source,

+ NetLogSource source,

NetLogEventPhase phase,

std::unique_ptr<base::DictionaryValue> params)

: type(type),