Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: net/log/test_net_log.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/test_net_log.cc
diff --git a/net/log/test_net_log.cc b/net/log/test_net_log.cc
index 1b8bb549ca6d5f4f76810f36c3213aa9ccf18ca7..aacb6553d3e762488af36d63388c5ec8d2c110c3 100644
--- a/net/log/test_net_log.cc
+++ b/net/log/test_net_log.cc
@@ -7,6 +7,9 @@
#include "base/macros.h"
#include "base/synchronization/lock.h"
#include "base/values.h"
+#include "net/log/net_log_capture_mode.h"
+#include "net/log/net_log_entry.h"
+#include "net/log/net_log_source.h"
#include "net/log/net_log_source_type.h"
namespace net {
@@ -25,7 +28,7 @@ class TestNetLog::Observer : public NetLog::ThreadSafeObserver {
}
// Fills |entry_list| with all entries in the log from the specified Source.
- void GetEntriesForSource(NetLog::Source source,
+ void GetEntriesForSource(NetLogSource source,
TestNetLogEntry::List* entry_list) const {
base::AutoLock lock(lock_);
entry_list->clear();
@@ -48,7 +51,7 @@ class TestNetLog::Observer : public NetLog::ThreadSafeObserver {
private:
// ThreadSafeObserver implementation:
- void OnAddEntry(const NetLog::Entry& entry) override {
+ void OnAddEntry(const NetLogEntry& entry) override {
// Using Dictionaries instead of Values makes checking values a little
// simpler.
std::unique_ptr<base::DictionaryValue> param_dict =
@@ -86,7 +89,7 @@ void TestNetLog::GetEntries(TestNetLogEntry::List* entry_list) const {
observer_->GetEntries(entry_list);
}
-void TestNetLog::GetEntriesForSource(NetLog::Source source,
+void TestNetLog::GetEntriesForSource(NetLogSource source,
TestNetLogEntry::List* entry_list) const {
observer_->GetEntriesForSource(source, entry_list);
}
@@ -115,7 +118,7 @@ void BoundTestNetLog::GetEntries(TestNetLogEntry::List* entry_list) const {
}
void BoundTestNetLog::GetEntriesForSource(
- NetLog::Source source,
+ NetLogSource source,
TestNetLogEntry::List* entry_list) const {
test_net_log_.GetEntriesForSource(source, entry_list);
}

Powered by Google App Engine
This is Rietveld 408576698