net/log/bounded_file_net_log_observer.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/bounded_file_net_log_observer.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/bounded_file_net_log_observer.cc

diff --git a/net/log/bounded_file_net_log_observer.cc b/net/log/bounded_file_net_log_observer.cc

index 0f1eafdf58a7dda73fb50dd8b8ac8b4ff2098a5a..833e84753d522884027fe21643059bcaba6723d6 100644

--- a/net/log/bounded_file_net_log_observer.cc

+++ b/net/log/bounded_file_net_log_observer.cc

@@ -17,6 +17,7 @@

#include "base/synchronization/lock.h"

#include "base/threading/thread.h"

#include "base/values.h"

+#include "net/log/net_log_entry.h"

#include "net/log/net_log_util.h"

#include "net/url_request/url_request_context.h"

@@ -248,7 +249,7 @@ void BoundedFileNetLogObserver::StopObserving(

net_log()->DeprecatedRemoveObserver(this);

}

-void BoundedFileNetLogObserver::OnAddEntry(const NetLog::Entry& entry) {

+void BoundedFileNetLogObserver::OnAddEntry(const NetLogEntry& entry) {

std::unique_ptr<std::string> json(new std::string);

// If |entry| cannot be converted to proper JSON, ignore it.