net/http/http_stream_factory_impl_job.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1718)

My Issues | Starred Open | Closed | All

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/http/http_stream_factory_impl_job.h ('k') | net/http/http_stream_factory_impl_job_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index 968b148adba41d18a6fba9741a9a3cbe50e21550..06cf1bbbb3d83ebb7aed0e02d308cf617919da0a 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -35,8 +35,9 @@

#include "net/http/http_server_properties.h"

#include "net/http/http_stream_factory.h"

#include "net/http/http_stream_factory_impl_request.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_capture_mode.h"

#include "net/log/net_log_event_type.h"

+#include "net/log/net_log_source.h"

#include "net/log/net_log_source_type.h"

#include "net/quic/chromium/quic_http_stream.h"

#include "net/socket/client_socket_handle.h"

@@ -116,7 +117,7 @@ void RecordChannelIDKeyMatch(SSLClientSocket* ssl_socket,

// Returns parameters associated with the start of a HTTP stream job.

std::unique_ptr<base::Value> NetLogHttpStreamJobCallback(

- const NetLog::Source& source,

+ const NetLogSource& source,

const GURL* original_url,

const GURL* url,

const AlternativeService* alternative_service,

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « net/http/http_stream_factory_impl_job.h ('k') | net/http/http_stream_factory_impl_job_controller.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698