Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: net/disk_cache/net_log_parameters.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/net_log_parameters.h
diff --git a/net/disk_cache/net_log_parameters.h b/net/disk_cache/net_log_parameters.h
index 2bbed1232d5ccfc37304b3df3ba1267c85a7d82e..86c5c3cc5b1ee6c39d05e8b6bcff4482f3864fde 100644
--- a/net/disk_cache/net_log_parameters.h
+++ b/net/disk_cache/net_log_parameters.h
@@ -9,9 +9,13 @@
#include <string>
-#include "net/log/net_log.h"
+#include "net/log/net_log_parameters_callback.h"
-// This file contains a set of functions to create NetLog::ParametersCallbacks
+namespace net {
+struct NetLogSource;
+}
+
+// This file contains a set of functions to create NetLogParametersCallbacks
// shared by EntryImpls and MemEntryImpls.
namespace disk_cache {
@@ -21,41 +25,40 @@ class Entry;
// Entry. Contains the Entry's key and whether it was created or opened.
// |entry| can't be NULL, must support GetKey(), and must outlive the returned
// callback.
-net::NetLog::ParametersCallback CreateNetLogEntryCreationCallback(
+net::NetLogParametersCallback CreateNetLogEntryCreationCallback(
const Entry* entry,
bool created);
// Creates a NetLog callback that returns parameters for start of a non-sparse
// read or write of an Entry. For reads, |truncate| must be false.
-net::NetLog::ParametersCallback CreateNetLogReadWriteDataCallback(
- int index,
- int offset,
- int buf_len,
- bool truncate);
+net::NetLogParametersCallback CreateNetLogReadWriteDataCallback(int index,
+ int offset,
+ int buf_len,
+ bool truncate);
// Creates a NetLog callback that returns parameters for when a non-sparse
// read or write completes. For reads, |truncate| must be false.
// |bytes_copied| is either the number of bytes copied or a network error
// code. |bytes_copied| must not be ERR_IO_PENDING, as it's not a valid
// result for an operation.
-net::NetLog::ParametersCallback CreateNetLogReadWriteCompleteCallback(
+net::NetLogParametersCallback CreateNetLogReadWriteCompleteCallback(
int bytes_copied);
// Creates a NetLog callback that returns parameters for when a sparse
// operation is started.
-net::NetLog::ParametersCallback CreateNetLogSparseOperationCallback(
+net::NetLogParametersCallback CreateNetLogSparseOperationCallback(
int64_t offset,
int buf_len);
// Creates a NetLog callback that returns parameters for when a read or write
// for a sparse entry's child is started.
-net::NetLog::ParametersCallback CreateNetLogSparseReadWriteCallback(
- const net::NetLog::Source& source,
+net::NetLogParametersCallback CreateNetLogSparseReadWriteCallback(
+ const net::NetLogSource& source,
int child_len);
// Creates a NetLog callback that returns parameters for when a call to
// GetAvailableRange returns.
-net::NetLog::ParametersCallback CreateNetLogGetAvailableRangeResultCallback(
+net::NetLogParametersCallback CreateNetLogGetAvailableRangeResultCallback(
int64_t start,
int result);

Powered by Google App Engine
This is Rietveld 408576698