net/disk_cache/blockfile/entry_impl.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/entry_impl.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/entry_impl.h

diff --git a/net/disk_cache/blockfile/entry_impl.h b/net/disk_cache/blockfile/entry_impl.h

index 893afba62940e0e6dc9343beb051eec27d2b121c..45bfcbcc0c631af3f0f904d6fe18eb7d0aa0f0c4 100644

--- a/net/disk_cache/blockfile/entry_impl.h

+++ b/net/disk_cache/blockfile/entry_impl.h

@@ -8,13 +8,18 @@

#include <stdint.h>

#include <memory>

+#include <string>

#include "base/macros.h"

#include "net/disk_cache/blockfile/disk_format.h"

#include "net/disk_cache/blockfile/storage_block-inl.h"

#include "net/disk_cache/blockfile/storage_block.h"

#include "net/disk_cache/disk_cache.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

+namespace net {

+class NetLog;

namespace disk_cache {