jingle/glue/fake_ssl_client_socket_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/glue/fake_ssl_client_socket_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: jingle/glue/fake_ssl_client_socket_unittest.cc

diff --git a/jingle/glue/fake_ssl_client_socket_unittest.cc b/jingle/glue/fake_ssl_client_socket_unittest.cc

index b8955f0e8cebb5a03d0fe6aee813ec9c7b7568a1..c3065c12993d86565f02be7ac09eebdd90aaba93 100644

--- a/jingle/glue/fake_ssl_client_socket_unittest.cc

+++ b/jingle/glue/fake_ssl_client_socket_unittest.cc

@@ -18,7 +18,8 @@

#include "net/base/io_buffer.h"

#include "net/base/ip_address.h"

#include "net/base/test_completion_callback.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_source.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/socket_test_util.h"

#include "net/socket/stream_socket.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -102,7 +103,7 @@ class FakeSSLClientSocketTest : public testing::Test {

std::unique_ptr<net::StreamSocket> MakeClientSocket() {

return mock_client_socket_factory_.CreateTransportClientSocket(

- net::AddressList(), NULL, NULL, net::NetLog::Source());

+ net::AddressList(), NULL, NULL, net::NetLogSource());

}

void SetData(const net::MockConnect& mock_connect,