google_apis/gcm/engine/connection_factory_impl.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index 203e0e84b36f594174d02df376daafac4c19a29e..3fec71ef74952b3a68a8ff1df8246d11f4fd1441 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -18,7 +18,6 @@

#include "net/base/net_errors.h"

#include "net/http/http_network_session.h"

#include "net/http/http_request_headers.h"

-#include "net/log/net_log.h"

#include "net/log/net_log_source_type.h"

#include "net/proxy/proxy_info.h"

#include "net/socket/client_socket_handle.h"