extensions/browser/api/socket/udp_socket.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/udp_socket.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/udp_socket.cc

diff --git a/extensions/browser/api/socket/udp_socket.cc b/extensions/browser/api/socket/udp_socket.cc

index e65957493849ae6d1b85eb500974e712870ecfe6..f715ca774c25b17db2a7d79e6e5f98d811b00834 100644

--- a/extensions/browser/api/socket/udp_socket.cc

+++ b/extensions/browser/api/socket/udp_socket.cc

@@ -12,6 +12,7 @@

#include "net/base/ip_address.h"

#include "net/base/ip_endpoint.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "net/udp/datagram_socket.h"

#include "net/udp/udp_client_socket.h"

@@ -33,7 +34,7 @@ UDPSocket::UDPSocket(const std::string& owner_extension_id)

socket_(net::DatagramSocket::DEFAULT_BIND,

net::RandIntCallback(),

NULL,

- net::NetLog::Source()) {}

+ net::NetLogSource()) {}

UDPSocket::~UDPSocket() { Disconnect(); }