extensions/browser/api/socket/socket_api.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/socket_api.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/socket_api.cc

diff --git a/extensions/browser/api/socket/socket_api.cc b/extensions/browser/api/socket/socket_api.cc

index 1cc08146d7e6e2dc7341533334a68f8d825d946b..2d245fb09184973a314e5112691160f536db3692 100644

--- a/extensions/browser/api/socket/socket_api.cc

+++ b/extensions/browser/api/socket/socket_api.cc

@@ -11,6 +11,7 @@

#include "base/bind.h"

#include "base/containers/hash_tables.h"

#include "base/memory/ptr_util.h"

+#include "base/values.h"

#include "build/build_config.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/resource_context.h"

@@ -30,7 +31,7 @@

#include "net/base/net_errors.h"

#include "net/base/network_interfaces.h"

#include "net/base/url_util.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_context_getter.h"