content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc ('k') | content/browser/resolve_proxy_msg_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

index 7fb9f0a34ca92792f59a8fc4cfcd8f2a3e43535d..0c0b48d86c24009399b6a1ec023d4294ddfd186c 100644

--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

@@ -21,6 +21,7 @@

#include "net/base/io_buffer.h"

#include "net/base/net_errors.h"

#include "net/base/rand_callback.h"

+#include "net/log/net_log_source.h"

#include "net/udp/udp_socket.h"

#include "ppapi/c/pp_errors.h"

#include "ppapi/c/private/ppb_net_address_private.h"

@@ -405,7 +406,7 @@ void PepperUDPSocketMessageFilter::DoBind(

std::unique_ptr<net::UDPSocket> socket(

new net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,

- net::RandIntCallback(), NULL, net::NetLog::Source()));

+ net::RandIntCallback(), NULL, net::NetLogSource()));

std::vector<uint8_t> address;

uint16_t port;