content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « content/browser/renderer_host/pepper/pepper_network_proxy_host.cc ('k') | content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

index 20aebb97965a35c4513634f186cafa4bb74e36e8..50484811508e190b6a908ebb24f27012f7c845b7 100644

--- a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

@@ -19,6 +19,7 @@

#include "net/base/ip_address.h"

#include "net/base/ip_endpoint.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "ppapi/c/pp_errors.h"

#include "ppapi/c/private/ppb_net_address_private.h"

#include "ppapi/host/dispatch_host_message.h"

@@ -184,7 +185,7 @@ void PepperTCPServerSocketMessageFilter::DoListen(

state_ = STATE_LISTEN_IN_PROGRESS;

- socket_.reset(new net::TCPSocket(NULL, NULL, net::NetLog::Source()));

+ socket_.reset(new net::TCPSocket(NULL, NULL, net::NetLogSource()));

int net_result = net::OK;

do {

net::IPEndPoint ip_end_point(net::IPAddress(address), port);