content/browser/renderer_host/p2p/socket_host_udp.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_udp.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/p2p/socket_host_udp.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_udp.cc b/content/browser/renderer_host/p2p/socket_host_udp.cc

index b5358eb776056bcf7b3e4a5ad172e6cf8c3df88f..e4e744b7a461da46965ab147d9c7fd90dab47e65 100644

--- a/content/browser/renderer_host/p2p/socket_host_udp.cc

+++ b/content/browser/renderer_host/p2p/socket_host_udp.cc

@@ -20,6 +20,7 @@

#include "ipc/ipc_sender.h"

#include "net/base/io_buffer.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "third_party/webrtc/media/base/rtputils.h"

namespace {

@@ -445,7 +446,7 @@ bool P2PSocketHostUdp::SetOption(P2PSocketOption option, int value) {

std::unique_ptr<net::DatagramServerSocket>

P2PSocketHostUdp::DefaultSocketFactory() {

net::UDPServerSocket* socket = new net::UDPServerSocket(

- GetContentClient()->browser()->GetNetLog(), net::NetLog::Source());

+ GetContentClient()->browser()->GetNetLog(), net::NetLogSource());

#if defined(OS_WIN)

socket->UseNonBlockingIO();

#endif