content/browser/renderer_host/p2p/socket_host_tcp_server.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp_server.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/p2p/socket_host_tcp_server.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc

index 1bb35c1bde57b3979971d2e58c7586535117b3cc..fadd45bb5e64a60af997825f3a59560177249dd5 100644

--- a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc

+++ b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc

@@ -10,6 +10,7 @@

#include "content/common/p2p_messages.h"

#include "net/base/address_list.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "net/socket/stream_socket.h"

namespace {

@@ -23,7 +24,7 @@ P2PSocketHostTcpServer::P2PSocketHostTcpServer(IPC::Sender* message_sender,

P2PSocketType client_type)

: P2PSocketHost(message_sender, socket_id, P2PSocketHost::TCP),

client_type_(client_type),

- socket_(new net::TCPServerSocket(nullptr, net::NetLog::Source())),

+ socket_(new net::TCPServerSocket(nullptr, net::NetLogSource())),

accept_callback_(base::Bind(&P2PSocketHostTcpServer::OnAccepted,

base::Unretained(this))) {

}