content/browser/devtools/protocol/tethering_handler.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tethering_handler.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/tethering_handler.cc

diff --git a/content/browser/devtools/protocol/tethering_handler.cc b/content/browser/devtools/protocol/tethering_handler.cc

index 3f9b8ad60c28796381049c1002d9f21b209e4af1..38a5118761ef02f65a897d241be726564f650c2b 100644

--- a/content/browser/devtools/protocol/tethering_handler.cc

+++ b/content/browser/devtools/protocol/tethering_handler.cc

@@ -9,6 +9,7 @@

#include "net/base/io_buffer.h"

#include "net/base/ip_address.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "net/socket/server_socket.h"

#include "net/socket/stream_socket.h"

#include "net/socket/tcp_server_socket.h"

@@ -161,7 +162,7 @@ class BoundSocket {

const CreateServerSocketCallback& socket_callback)

: accepted_callback_(accepted_callback),

socket_callback_(socket_callback),

- socket_(new net::TCPServerSocket(NULL, net::NetLog::Source())),

+ socket_(new net::TCPServerSocket(NULL, net::NetLogSource())),

port_(0) {

}