components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « components/certificate_transparency/log_dns_client_unittest.cc ('k') | components/cronet/android/test/test_upload_data_stream_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc

diff --git a/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc b/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc

index 8a5e05df79c879183033c9ed7ed1cd0fa5449a60..237d65663fececc6e6bc885439f38af17e38c760 100644

--- a/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc

+++ b/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc

@@ -19,7 +19,7 @@

#include "net/cert/cert_verify_result.h"

#include "net/cert/mock_cert_verifier.h"

#include "net/cert/x509_certificate.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

#include "net/test/cert_test_util.h"

#include "net/test/test_data_directory.h"

#include "testing/gtest/include/gtest/gtest.h"